Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a junit5-vintage-consumer module that demonstrates running under JUnit 4 #10

Closed
smoyer64 opened this issue Jun 21, 2016 · 9 comments

Comments

@smoyer64
Copy link
Contributor

In support of the documentation change described by junit-team/junit5#292.

@sbrannen
Copy link
Member

The junit5-maven-consumer already demonstrates how to execute JUnit Jupiter tests alongside JUnit Vintage tests.

What else did you have in mind?

@smoyer64
Copy link
Contributor Author

It does indeed have both vintage and jupiter tests. I was envisioning an example that had included a JUnit4 test suite built with @RunWith(JUnitPlatform.class) and @SelectPackages and @SelectClasses as needed but it does seem like a duplication of what's already in this module. Since these examples are intended to be run via Maven, I had also envisioned examples of how to run the tests from the CLI.

@sbrannen
Copy link
Member

from the CLI?

Isn't running mvn clean test the command line?

Or do you mean you want to see an example project that uses the ConsoleLauncher?

@sbrannen
Copy link
Member

As for including an example suite using @RunWith(JUnitPlatform.class), I think that's a good idea actually.

@smoyer64
Copy link
Contributor Author

Yes ... there were questions (issues) in the junit5 tracker that implied more information was needed on exactly how to run ConsoleLauncher.

@sbrannen
Copy link
Member

Perhaps you'd like to create an issue or PR to address the ConsoleLauncher... ?

@sbrannen
Copy link
Member

FYI: this is likely the issue you were alluding to: junit-team/junit5#155

@sormuras
Copy link
Member

2+ years and most build tools and IDEs don't longer require the @RunWith(JUnitPlatform.class) mode, as they support the JUnit Platform natively.

About to close this issue. Objections?

@sbrannen
Copy link
Member

No objection from me.

We just need to get "real" support for suites in the Platform...

@sormuras sormuras closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants