Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write micro-tests for classes in junit-commons #109

Closed
marcphilipp opened this issue Jan 13, 2016 · 7 comments
Closed

Write micro-tests for classes in junit-commons #109

marcphilipp opened this issue Jan 13, 2016 · 7 comments
Assignees
Milestone

Comments

@marcphilipp
Copy link
Member

No description provided.

@marcphilipp marcphilipp added this to the Alpha 1 milestone Jan 13, 2016
@sbrannen sbrannen self-assigned this Jan 13, 2016
@marcphilipp marcphilipp modified the milestones: 5.0 M1, 5.0 Alpha Jan 26, 2016
@marcphilipp marcphilipp changed the title Document and test junit-commons Write micro-tests for classes in junit-commons Apr 15, 2016
@lutovich
Copy link
Contributor

I would like to help with this but it seems most non-trivial classes from junit-commons already have pretty good test coverage. @marcphilipp could you please elaborate what should be done as part of this task?

@sbrannen
Copy link
Member

@lutovich, basically just go through each utility in the org.junit.gen5.commons.util package in the junit-commons module, and for each non-private method, ensure that there is sufficient coverage in a corresponding test class in the org.junit.gen5.commons.util package in the junit-tests module.

Make sense?

@lutovich
Copy link
Contributor

Yes, understood. I can do this.

@sbrannen
Copy link
Member

Cool. thanks!

@lutovich
Copy link
Contributor

@sbrannen I'm still working on this task, here is the branch https://github.com/lutovich/junit5/tree/issue109-tests-junit-commons. This will take couple more days.

@sbrannen
Copy link
Member

I took a quick look and made some minor suggestions.

Keep up the good work, and thanks for helping us out!

@sbrannen
Copy link
Member

sbrannen commented May 6, 2016

PR #236 has been merged into master in commit 2dfd654.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants