Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./gradlew build fails due to checkstyle errors #3268

Closed
mpkorstanje opened this issue Apr 23, 2023 · 5 comments
Closed

./gradlew build fails due to checkstyle errors #3268

mpkorstanje opened this issue Apr 23, 2023 · 5 comments

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Apr 23, 2023

Steps to reproduce

Checkout main (currently at 07f2bf3) and run:

 ./gradlew build
...
> Task :checkstyleNohttp
[ant:checkstyle] [ERROR] /home/mpkorstanje/Projects/junit-team/junit5/buildSrc/build/generated-sources/kotlin-dsl-accessors/kotlin/gradle/kotlin/dsl/accessors/_01a7fddcf81aa279b379d6fe3cb64505/Accessors8lcri9ibgd9oj8dt3t8z8nvfx.kt:9:10: http:// URLs are not allowed but got 'http://www.apache.org/licenses/LICENSE-2.0'. Use https:// instead. [NoHttp]

[many more of these]
...

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleNohttp'.
> A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction
   > Checkstyle rule violations were found. See the report at: file:///home/mpkorstanje/Projects/junit-team/junit5/build/reports/checkstyleNohttp/nohttp.html
     Checkstyle files with violations: 719
     Checkstyle violations by severity: [error:719]

...

Looks like the generated code is included in the check style. This code includes a http link to the Apache Licence,

@marcphilipp
Copy link
Member

buildSrc was deleted in #3149. Please delete it manually which should only be necessary once.

@marcphilipp marcphilipp closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2023
@sbrannen sbrannen self-assigned this Apr 23, 2023
@sbrannen sbrannen modified the milestones: 5.11.0-M1, 5.10.0-M1 Apr 23, 2023
@marcphilipp marcphilipp removed this from the 5.10.0-M1 milestone Apr 23, 2023
@sbrannen
Copy link
Member

buildSrc was deleted in #3149. Please delete it manually which should only be necessary once.

Well, it will keep reappearing if you switch between 5.9.x and main, like what just happened to me.

But... I guess that won't happen verify often. 😇

@sbrannen
Copy link
Member

Side note: you may have to stop the Gradle daemon to delete that folder.

At least I had to.

@marcphilipp
Copy link
Member

I pushed 918f097 to avoid having to fight that for the time being.

@mpkorstanje
Copy link
Contributor Author

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants