Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TestEngines to be completely dynamic #367

Closed
1 task done
sbrannen opened this issue Jun 29, 2016 · 2 comments
Closed
1 task done

Allow TestEngines to be completely dynamic #367

sbrannen opened this issue Jun 29, 2016 · 2 comments

Comments

@sbrannen
Copy link
Member

sbrannen commented Jun 29, 2016

Status Quo

It is currently impossible to create a custom TestEngine that is completely dynamic in nature.

The reason is that a completely dynamic engine will not have any statically registered children and will therefore get summarily pruned by org.junit.platform.launcher.core.Root.pruneEmptyTestEngines().

Deliverables

  • Allow test engines to be completely dynamic (i.e., don't prune engines without children).
@sbrannen
Copy link
Member Author

sbrannen commented Jun 29, 2016

@junit-team/junit-lambda, let's discuss the merits of this proposal.

See also #366, which was the impetus for this proposal. Pay special attention to the fact that one has to create a dummy container TestDescriptor and add it to the engine in order to prevent the dynamic engine from getting pruned. See the inline comments in DynamicTestEngine.discover() in 47d20a7 for details.

@sbrannen
Copy link
Member Author

sbrannen commented Jul 4, 2016

in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant