Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism for launcher to detect engine capabilities #90

Open
jlink opened this issue Jan 6, 2016 · 15 comments
Open

Add mechanism for launcher to detect engine capabilities #90

jlink opened this issue Jan 6, 2016 · 15 comments

Comments

@jlink
Copy link
Contributor

jlink commented Jan 6, 2016

Use cases:

  • Launcher gives warning if a Specification (e.g. AllTestsSpecification) is not supported, so that user knows that their tests might not be picked up as expected.
  • IDE/Launcher switches on features (e.g. Tagging) only if all/some registered engines support it.
  • Launcher/IDE won't use features that break backwards compatibility

Potential capabilities to announce:

  • Supported specifications
  • Tagging
  • Engine filters
  • Support for opentest4j
  • Custom events
  • Supported API version (starting with 5.0)?

This feature needs both:

  • A way for engines to declare their capabilities
  • A way for users of launcher to find out about capabilities
@jlink jlink added this to the M1 milestone Jan 6, 2016
@marcphilipp
Copy link
Member

Another potential capability: Parallelization

@saint88
Copy link

saint88 commented Apr 4, 2018

Hello
When you plan to add a parallel launch of tests in Junit 5 via the plugin maven surefire.

@saint88
Copy link

saint88 commented Apr 4, 2018

It's critical options for migrate our peroject from junit 4.12 to Jupiter

@sormuras
Copy link
Member

sormuras commented Apr 4, 2018

Jupiter will soon support parallel execution: see #60 and the related feature branch https://github.com/junit-team/junit5/tree/experiments/parallel-execution

@saint88
Copy link

saint88 commented Apr 4, 2018

Ok. Thanks. I will be wait. =)

@jlink
Copy link
Contributor Author

jlink commented Apr 4, 2018 via email

@sormuras
Copy link
Member

sormuras commented Apr 4, 2018

Maybe. At the moment, it's just an opt-in feature of the Jupiter engine.

Wanted to direct @saint88 to #60 to keep this issue free from Jupiter-related requests.

@marcphilipp
Copy link
Member

@jlink I'm working on #60 with @leonard84 since Spock also wants to add support for parallel execution. Engines that extend HierarchicalTestEngine will be able to use it so it is kind of a Platform feature. However, we believe it should be possible to enable/disable parallel execution per engine.

@aaronq
Copy link

aaronq commented Apr 26, 2018

@marcphilipp do you know when your parallel changes will get released?

@marcphilipp
Copy link
Member

@aaronq The plan is to polish them and publish them as experimental in 5.3 M1... so 1-2 months.

@sormuras
Copy link
Member

Bump/touch.

Especially the "warning part" is crucial when debugging a "No tests found" error message after a test run that should have found tests. For example: engines are present, select source test sources, filters are okay, ... but no engine supports the selected selectors.

@sormuras sormuras self-assigned this Dec 18, 2018
@stale
Copy link

stale bot commented May 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the status: stale label May 13, 2021
@leonard84
Copy link
Collaborator

This feature would have helped with spockframework/spock#1288

@stale stale bot removed the status: stale label May 14, 2021
@marcphilipp marcphilipp removed this from the 5.x Backlog milestone Jun 19, 2021
@stale
Copy link

stale bot commented Jun 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. Given the limited bandwidth of the team, it will be automatically closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the status: stale label Jun 21, 2022
@leonard84
Copy link
Collaborator

I'd say it is still relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants