You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have set patchreview_split_right to 1 and this work OK for the PatchReview command, but when I use DiffReview, the changes are still on the left, while I'd prefer them on the right.
Now, this could be by design (it's a "patchreview" setting after all), but in that case I'd like to see a "diffreview_split_right" setting if possible.
Thank you.
The text was updated successfully, but these errors were encountered:
I can't reproduce this problem locally. What vim version/platform and patchreview.vim plugin version etc. are you running? Does changing g:patchreview_split_right to 0 instead give you the correct behavior for DiffReview?
I changed it and I now get the correct behaviour. So I guess it's just a misunderstanding of the functionality on my part. Am I corret that this the intended behaviour:
For patchreview, "current source" is the file without the patch applied, "diff" is the file with patches applied
For diffreview, "current source" is the current state of the workspace, "diff" is the parent revision
I thought diffreview would use the parent as the current source and the changes on top of that as the diff, but I realize I was just wrong there. So this can be closed.
I have set patchreview_split_right to 1 and this work OK for the PatchReview command, but when I use DiffReview, the changes are still on the left, while I'd prefer them on the right.
Now, this could be by design (it's a "patchreview" setting after all), but in that case I'd like to see a "diffreview_split_right" setting if possible.
Thank you.
The text was updated successfully, but these errors were encountered: