Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made url clickable #1138

Merged
merged 2 commits into from Oct 30, 2020
Merged

made url clickable #1138

merged 2 commits into from Oct 30, 2020

Conversation

fayeed
Copy link
Member

@fayeed fayeed commented Oct 28, 2020

No description provided.

@fayeed fayeed linked an issue Oct 28, 2020 that may be closed by this pull request
Hyperlinked text #1129
Closed
@sunyae2
Copy link
Member

sunyae2 commented Oct 29, 2020

Looks like the url only catches text with the prefix https://www. - let's expand this to include www., http://, and https:// only prefixes as well

@fayeed
Copy link
Member Author

fayeed commented Oct 29, 2020 •
edited

@sunyatax sure will fix this.

@fayeed
Copy link
Member Author

fayeed commented Oct 29, 2020

@sunyatax I think we have an underline too for the URLs, what do you think?

@fayeed
Copy link
Member Author

fayeed commented Oct 29, 2020

@sunyatax This should be good to merge now

@fayeed
Copy link
Member Author

fayeed commented Oct 30, 2020

@sunyatax Can we merge this?

@sunyae2 sunyae2 merged commit 18ec4e8 into dev Oct 30, 2020
@sunyae2 sunyae2 deleted the content-url branch October 30, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hyperlinked text
2 participants
@fayeed @sunyae2