New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update of stomp py #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorhos
reviewed
Dec 26, 2022
ricardochaves
requested changes
Jan 6, 2023
ricardochaves
requested changes
Jan 6, 2023
victorhos
reviewed
Jan 9, 2023
victorhos
reviewed
Jan 9, 2023
victorhos
reviewed
Jan 9, 2023
ricardochaves
requested changes
Jan 16, 2023
Kudos, SonarCloud Quality Gate passed! |
ricardochaves
approved these changes
Jan 16, 2023
victorhos
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being delivered?
Updates
stomp.py
to its current latest version (8.1.0
)Changing some log messages to lower case
What impacts?
No impacts are expected only the updates of the dependencies.
Evidences
Connected to a test broker, some tests were made to ensure that the update is working as expected. Below are the evidences of these tests.
The test should create a queue called
/queue/my-test-destination
in broker and send the message. In the image below we can see that.After that a test release of the library was published on the test pypi. And this test version was installed in a project locally, also connected to the test broker. Doing some tests the queue was also created and the message sent.