Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training on Piano Roll data #28

Closed
rafaelvalle opened this issue Jun 29, 2018 · 6 comments
Closed

Training on Piano Roll data #28

rafaelvalle opened this issue Jun 29, 2018 · 6 comments

Comments

@rafaelvalle
Copy link

rafaelvalle commented Jun 29, 2018

Hey Jun-Yan, thanks for putting this repo together.
I'm trying to train it on piano roll data and have been seeing unexpected behavior: the generator outputs the same image even though the conditions, i.e. noise vector and real A, change.

Any thoughts on what it could be? I've added the loss log, options, output images during training and output images during inference.

loss_log.txt
opt.txt

Model outputs during training(fake_b_encoded, fake_b_random, real_a_encoded,real_b_encoded)
fake_b_encoded fake_b_random real_a_encoded real_b_encoded

model.set_input(data)
encode = False
z_samples = model.get_z_random(1, opt.nz)
real_A, fake_B, real_B = model.test(z_samples, encode=encode)

Model outputs during inference(real_a, real_b, fake_b)

iModel output during inference

@junyanz
Copy link
Owner

junyanz commented Jul 3, 2018

I am not familiar with the piano roll data. Is it for future prediction? The current generator architectures assume strong spatial alignment between input and output, which might not be the case of your application. It also seems that L1 reconstruction does not work for your application as most of the pixels are black.

@rafaelvalle
Copy link
Author

Yes, it is for future prediction. Does the spatial alignment come from the concatenation of features?
With other architectures L1 didn't seem to help...

@junyanz
Copy link
Owner

junyanz commented Jul 4, 2018

Our generator architecture works well for spatially aligned data. It might be struggling with other types of data.

@rafaelvalle
Copy link
Author

What in your generator's architecture makes it work well for spatially aligned data?

@junyanz
Copy link
Owner

junyanz commented Jul 13, 2018

The generator is a U-Net with many skip connections. Please see the original paper for more details. Also, check out Sec 3.2.1 in the pix2pix paper.

@rafaelvalle
Copy link
Author

Thank you for pointing out the section in the paper. I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants