Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Improve automated PR validation system #92

Closed
9yoi opened this issue Mar 6, 2023 · 3 comments
Closed

Improve automated PR validation system #92

9yoi opened this issue Mar 6, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@9yoi
Copy link
Contributor

9yoi commented Mar 6, 2023

Needed:

  • Linting: Changes to Validated-tokens.csv from community PRs should follow the format in the file (Trailing new line, no spaces between fields)
  • Validate change request against on-chain metadata (Is the metadata I am adding to the file the same as what is reported on chain for this token?)
    // TODO: match with onchain data

Tech readme: https://github.com/jup-ag/token-list/blob/main/README-developers.md

If you're interested, comment here or DM us in discord.

@McSam94 @ZhengYuTay

@9yoi 9yoi added the good first issue Good for newcomers label Mar 6, 2023
@docongminh
Copy link

@McSam94 Could you assign this issue for me with more detail requirement and specification ? Thanks!

@9yoi
Copy link
Contributor Author

9yoi commented Mar 15, 2023

@McSam94 Could you assign this issue for me with more detail requirement and specification ? Thanks!

Hi @docongminh! Thanks for asking. I edited the description to clarify -- do you have more questions?

@DrCryptonite
Copy link

Is this issue still needed?

I think we need an API to lookup the Token data on chain then that can be added to the Validate TS

@9yoi 9yoi closed this as completed Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants