New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PowerShell Script for Windows users #158

Merged
merged 2 commits into from Jul 4, 2017

Conversation

Projects
None yet
2 participants
@3Dcube
Contributor

3Dcube commented Jun 28, 2017

No description provided.

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Jul 3, 2017

Collaborator

Thanks! I can't test that straightaway (having a few issues with my Windows VM...), I'll merge anyway.

One remark though: could you use the full coursier URL (https://github.com/coursier/coursier/raw/v1.0.0-RC1/coursier to be in sync with the jupyter-scala script) instead of the shortened one? That states what is downloaded more explicitly.

Collaborator

alexarchambault commented Jul 3, 2017

Thanks! I can't test that straightaway (having a few issues with my Windows VM...), I'll merge anyway.

One remark though: could you use the full coursier URL (https://github.com/coursier/coursier/raw/v1.0.0-RC1/coursier to be in sync with the jupyter-scala script) instead of the shortened one? That states what is downloaded more explicitly.

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Jul 4, 2017

Collaborator

Merging, thanks!

Collaborator

alexarchambault commented Jul 4, 2017

Merging, thanks!

@alexarchambault alexarchambault merged commit 98bac70 into jupyter-scala:master Jul 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment