Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elyra needs to recognize loopback scenario in socket mode #59

Closed
kevin-bates opened this issue Jul 7, 2017 · 3 comments
Closed

Elyra needs to recognize loopback scenario in socket mode #59

kevin-bates opened this issue Jul 7, 2017 · 3 comments
Assignees
Milestone

Comments

@kevin-bates
Copy link
Member

kevin-bates commented Jul 7, 2017

On configurations where the elyra server is also a worker node, socket mode requests will timeout if the kernel lands on the elyra node because it never receives the connection information. This is because the kernel launcher received a reference to an existing file and assumes 'push' mode.

What is really happening is that, in this case, because the assignment landed on the elyra server, the connection information created by default is valid. So because the file is not empty, the launcher will behave as if the connection file mode is 'push' and just use the file its given. In this case, Elyra should break out of its loop waiting for a socket response (assuming its in the RUNNING state) and just continue - since the original file is valid.

@kevin-bates kevin-bates added this to the Sprint 5 milestone Jul 7, 2017
@ckadner
Copy link
Collaborator

ckadner commented Jul 7, 2017

good catch @kevin-bates !

@kevin-bates kevin-bates self-assigned this Jul 10, 2017
@kevin-bates
Copy link
Member Author

Opened PR #63.

@kevin-bates
Copy link
Member Author

PR #63 has been merged - closing this issue.

@kevin-bates kevin-bates modified the milestones: Sprint 5, v0.6 Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants