Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should consider adding a namespace to launcher options #80

Closed
kevin-bates opened this issue Jul 17, 2017 · 1 comment
Closed

Should consider adding a namespace to launcher options #80

kevin-bates opened this issue Jul 17, 2017 · 1 comment

Comments

@kevin-bates
Copy link
Member

We may want to consider adding a namespace indicator to launcher options sooner rather than later. Right now we only have --response-address, but we might want others. For each option, there's the chance that it collides with a pre-existing parameter. This can be avoided by prefixing all parameters with a namespace which is considered good practice anyway.

Some proposals include:
Elyra e.g., --Elyra.response-address
ElyraLauncher e.g., --ElyraLauncher.response-address
KernelLauncher e.g., --KernelLauncher.response-address

This would require changes to each of the launchers such that the appropriate parameter is processed.

@kevin-bates
Copy link
Member Author

kevin-bates commented Jul 27, 2017

Per discussion, we're going with a namespace of RemoteProcessProxy since jupyter convention is that parameter namespaces reflect the class to which they apply. This issue to Sprint 6.

@kevin-bates kevin-bates modified the milestones: Sprint 6, Backlog Jul 27, 2017
@kevin-bates kevin-bates self-assigned this Aug 1, 2017
@kevin-bates kevin-bates modified the milestones: Sprint 6, v0.6 Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant