Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Links fails right after a new release #131

Closed
jtpio opened this issue Sep 7, 2021 · 1 comment
Closed

Check Links fails right after a new release #131

jtpio opened this issue Sep 7, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@jtpio
Copy link
Member

jtpio commented Sep 7, 2021

Problem

When a new release has been published with the commit and tag created on the main branch:

image

The check release script triggered on a new PR can fail with the following:

image

Example PR: jtpio/ipylab#76
Example run: https://github.com/jtpio/ipylab/runs/3526255104

Proposed Solution

This seems to be because there is no new change since the last tag when generating the changelog (None).

Maybe the fix could be to default the Full Changelog url to use the latest tag instead of None.

Additional context

@blink1073
Copy link
Contributor

Fixed by #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants