Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static content with base_url #282

Closed
echarles opened this issue Aug 23, 2020 · 4 comments · Fixed by #285
Closed

Static content with base_url #282

echarles opened this issue Aug 23, 2020 · 4 comments · Fixed by #285

Comments

@echarles
Copy link
Member

echarles commented Aug 23, 2020

Current behavior when you run with a base_url with jupyter server --ServerApp.jpserver_extensions="{'simple_ext1': True}" --ServerApp.base_url=/my_prefix

I can understand static content is nicely segregated by /static/extension_name/... but with reverse proxy, deployments typically serve all content (static + dynamic) behind a fixed prefix /my_prefix which is not the case here.

Do we keep this like that or do we evolve to /my_prefix/static/extension_name/...?
Based on the decision, we will need to fix JupyterLab.

cc/ @Zsailer @blink1073

@echarles echarles changed the title [DISCUSS] Static content with base_url Static content with base_url Aug 24, 2020
@blink1073
Copy link
Collaborator

I agree, base_url should always take priority, such as /myorg/static/lab, and /myorg/lab.

@Zsailer
Copy link
Member

Zsailer commented Aug 24, 2020

I agree, base_url should always take priority, such as /myorg/static/lab, and /myorg/lab.

👍

@echarles
Copy link
Member Author

This is on the jlab critical path. @Zsailer If the changes are not too difficult, just gimme pointers and I can open a PR. If the changes are large, maybe I will leave it to you if you have time...

@Zsailer
Copy link
Member

Zsailer commented Aug 24, 2020

I think it's a simple fix. I'm diving into it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants