-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Static content with base_url #282
Comments
I agree, |
👍 |
This is on the jlab critical path. @Zsailer If the changes are not too difficult, just gimme pointers and I can open a PR. If the changes are large, maybe I will leave it to you if you have time... |
I think it's a simple fix. I'm diving into it now |
Current behavior when you run with a base_url with
jupyter server --ServerApp.jpserver_extensions="{'simple_ext1': True}" --ServerApp.base_url=/my_prefix
/my_prefix
the http://localhost:8888/my_prefix/simple_ext1/default/my_prefix
http://localhost:8888/static/simple_ext1/home.htmlI can understand static content is nicely segregated by
/static/extension_name/...
but with reverse proxy, deployments typically serve all content (static + dynamic) behind a fixed prefix/my_prefix
which is not the case here.Do we keep this like that or do we evolve to
/my_prefix/static/extension_name/...
?Based on the decision, we will need to fix JupyterLab.
cc/ @Zsailer @blink1073
The text was updated successfully, but these errors were encountered: