Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to YDoc 0.2 #32

Merged
merged 2 commits into from
Sep 26, 2022
Merged

Update to YDoc 0.2 #32

merged 2 commits into from
Sep 26, 2022

Conversation

hbcarlos
Copy link
Member

No description provided.

@welcome
Copy link

welcome bot commented Sep 26, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

pyproject.toml Outdated
@@ -21,7 +21,7 @@ classifiers = [
]
requires-python = ">=3.7"
dependencies = [
"jupyter_ydoc>=0.1.16,<0.2.0",
"jupyter_ydoc>=0.2.0,<0.3.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could require jupyter_ydoc>=0.2.0,<0.4.0, and pin jupyter_ydoc>=0.2.0,<0.3.0 in JupyterLab v3 and jupyter_ydoc>=0.3.0a0 in JupyterLab v4?

@davidbrochart davidbrochart merged commit 160dac6 into jupyterlab:main Sep 26, 2022
@welcome
Copy link

welcome bot commented Sep 26, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@hbcarlos hbcarlos deleted the update_ydoc branch September 26, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants