Use Jupyter file ID service if installed #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 195 218 +23
=====================================
- Misses 195 218 +23
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davidbrochart
force-pushed
the
file_id
branch
2 times, most recently
from
a8da525
to
a645d9a
Compare
|
8db6b68 will need jupyter-server/jupyter_ydoc#81. |
davidbrochart
force-pushed
the
file_id
branch
from
8cd6859
to
0053f1b
Compare
davidbrochart
changed the title
davidbrochart
force-pushed
the
file_id
branch
from
9fa6d5d
to
38be0fc
Compare
davidbrochart
force-pushed
the
file_id
branch
from
38be0fc
to
fe98d7f
Compare
davidbrochart
commented
Oct 26, 2022
|
Awesome! |
hbcarlos
pushed a commit
to hbcarlos/jupyter-collaboration
that referenced
this pull request
Jan 29, 2023
* Use file ID * Get id2path from server settings * Remove jupyter_server_fileid dependency * get_file_info() doesn't return file_id * Set Y document path * Add GET room ID handler, directly access file ID manager * Call sync_all() if get_path(id) returns None * Change GET to PUT with body, return room ID * sync_all() is not needed anymore in jupyter_server_fileid v0.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.