Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass logger to YRoom, require ypy-websocket >=0.5.0 #58

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Pass logger to YRoom, require ypy-websocket >=0.5.0 #58

merged 2 commits into from
Nov 17, 2022

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Nov 16, 2022 •
edited

No description provided.

@davidbrochart davidbrochart marked this pull request as draft November 16, 2022 11:58
@davidbrochart davidbrochart force-pushed the ypy_websocket_0.5.0 branch 2 times, most recently from 1ec029f to 09c02ee Compare November 17, 2022 09:26
@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (d59fba4) compared to base (16bf915).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main     #58   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        263     276   +13     
=====================================
- Misses       263     276   +13
Impacted Files Coverage Δ
jupyter_server_ydoc/handlers.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidbrochart davidbrochart added the enhancement New feature or request label Nov 17, 2022
@davidbrochart davidbrochart marked this pull request as ready for review November 17, 2022 10:50
fcollonval
fcollonval requested changes Nov 17, 2022
View reviewed changes
jupyter_server_ydoc/handlers.py Outdated Show resolved Hide resolved
jupyter_server_ydoc/handlers.py Outdated Show resolved Hide resolved
jupyter_server_ydoc/handlers.py Outdated Show resolved Hide resolved
jupyter_server_ydoc/handlers.py Outdated Show resolved Hide resolved
@fcollonval
Copy link
Member

Thanks David

@davidbrochart
Copy link
Collaborator Author

Thanks for the review @fcollonval.
Sorry to not commit your changes directly, as I forced-pushed before seeing your review, and I don't know if it would have been OK.

@davidbrochart davidbrochart merged commit 7a024df into jupyterlab:main Nov 17, 2022
@davidbrochart davidbrochart deleted the ypy_websocket_0.5.0 branch November 17, 2022 13:43
@davidbrochart davidbrochart mentioned this pull request Nov 17, 2022
Merged
@fcollonval
Copy link
Member

Sorry to not commit your changes directly, as I forced-pushed before seeing your review, and I don't know if it would have been OK.

No problem

hbcarlos pushed a commit to hbcarlos/jupyter-collaboration that referenced this pull request Jan 29, 2023
@davidbrochart @hbcarlos
Pass logger to YRoom, require ypy-websocket >=0.5.0 (jupyterlab#58)
c4b3d5b 
* Pass logger to YRoom, require ypy-websocket >=0.5.0

* Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcollonval fcollonval fcollonval requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidbrochart @fcollonval