Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target to document change callback #72

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Add target to document change callback #72

merged 1 commit into from
Jan 17, 2023

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart marked this pull request as draft January 9, 2023 09:33
@codecov
Copy link

codecov bot commented Jan 9, 2023 •
edited

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (23f6dcd) compared to base (c42c27e).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main     #72   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          3       3           
  Lines        290     288    -2     
=====================================
+ Misses       290     288    -2
Impacted Files Coverage Δ
jupyter_server_ydoc/handlers.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidbrochart davidbrochart mentioned this pull request Jan 9, 2023
Merged
@hbcarlos
Copy link
Member

@davidbrochart Is this PR done? I need to update JupyterLab to ydoc v0.3.

@davidbrochart
Copy link
Collaborator Author

Oh I forgot about it, yes it's ready for review.

@davidbrochart davidbrochart marked this pull request as ready for review January 17, 2023 15:15
hbcarlos
hbcarlos approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@hbcarlos hbcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidbrochart davidbrochart merged commit 6e68404 into jupyterlab:main Jan 17, 2023
@davidbrochart
Copy link
Collaborator Author

I'll make a release now.

@davidbrochart davidbrochart deleted the jupyter_ydoc branch January 17, 2023 15:52
@davidbrochart
Copy link
Collaborator Author

Ah but we need jupyter_ydoc >=0.3.0a5, right?

@hbcarlos hbcarlos mentioned this pull request Jan 25, 2023
Closed
hbcarlos pushed a commit to hbcarlos/jupyter-collaboration that referenced this pull request Jan 29, 2023
@davidbrochart @hbcarlos
Add target to document change callback (jupyterlab#72)
eeb8d28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbcarlos hbcarlos hbcarlos approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidbrochart @hbcarlos