Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't package jupyter-ydoc 1.1.1 with jupyter-collaboration 1.2.1 #211

Closed
bnavigator opened this issue Jan 21, 2024 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@bnavigator
Copy link

Hi,

openSUSE rpm package maintainer for the jupyter ecosystem here.

I am at an impasse:

  1. jupyter-collaboration v2 and jupyter-ydoc v2 require pycrdt which is declared to be not ready for production yet
  2. jupyter-collaboration v1.2.1 requires
    "jupyter_ydoc>=1.0.1,<2.0.0", 
    "ypy-websocket>=0.12.1,<0.13.0",
    
  3. jupyter-ydoc 1.1.1 requires ypy-websocket >=0.8.3,<0.9.0 for testing.

Number 2 and 3 conflict with each other. Any advice?

@davidbrochart
Copy link
Collaborator

  1. jupyter-collaboration v2 and jupyter-ydoc v2 require pycrdt which is declared to be not ready for production yet

Ypy was not more ready for production, on the contrary. You shouldn't be worried about that.

Number 2 and 3 conflict with each other. Any advice?

I can release jupyter-ydoc v1.2.1 with a test requirement ypy-websocket>=0.12.1,<0.13.0, what do you think?

@bnavigator
Copy link
Author

bnavigator commented Jan 22, 2024

I tried running the test suit on 1.1.1 with ypy-websocket 0.12 and it failed.

If it's better to ignore the incubation phase warning and just update jupyter-collaboration and jupyter-ydoc to v2, I see no use in a jupyter-ydoc 1.2.1. I wonder what's the use of the backport releases and the 1.x branch in jupyter-collaboration then.

@davidbrochart
Copy link
Collaborator

I recommend upgrading jupyter-collaboration and jupyter-ydoc to v2 anyway, yes.
Backports are always good for dependencies which cannot upgrade, but it's still better to upgrade if you can.

@bnavigator
Copy link
Author

Thank you for the clarification.

I had to package y-py 0.7.0a1, which is nominally an alpha version, in order to enable the test suite for pycrdt. But I guess that is fine since there are no other consuming packages for it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants