Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load/auto-save document from the back-end using y-py #127

Merged
merged 1 commit into from Jul 6, 2022
Merged

Load/auto-save document from the back-end using y-py #127

merged 1 commit into from Jul 6, 2022

Conversation

davidbrochart
Copy link
Collaborator

@davidbrochart davidbrochart commented Dec 1, 2021 •
edited

@davidbrochart davidbrochart mentioned this pull request Dec 1, 2021
Merged
@davidbrochart davidbrochart marked this pull request as draft December 1, 2021 14:06
@davidbrochart davidbrochart mentioned this pull request Dec 1, 2021
Closed
@davidbrochart
Copy link
Collaborator Author

This last commit implements saving the document from the back-end entirely, by computing the document source using y-py. Tests are failing because y-py is not released yet.

@davidbrochart
Copy link
Collaborator Author

This PR will need jupyterlab/jupyterlab#11599 to be merged, because it populates the jupyter_ydoc entry point group with file and notebook Y document types, that are needed here.

@davidbrochart davidbrochart force-pushed the save_yjs branch 3 times, most recently from 21ef7da to d90add8 Compare March 25, 2022 09:14
@davidbrochart davidbrochart marked this pull request as ready for review March 31, 2022 07:13
@davidbrochart
Copy link
Collaborator Author

Trigger CI.

@davidbrochart davidbrochart reopened this Mar 31, 2022
@davidbrochart
Copy link
Collaborator Author

Ah, still need a JupyterLab release.

@davidbrochart davidbrochart marked this pull request as draft March 31, 2022 07:54
@davidbrochart davidbrochart marked this pull request as ready for review May 4, 2022 12:25
@davidbrochart davidbrochart changed the title Save document through Yjs websocket Load/auto-save document from the back-end using y-py May 5, 2022
@davidbrochart davidbrochart marked this pull request as draft May 5, 2022 15:58
@davidbrochart davidbrochart force-pushed the save_yjs branch 2 times, most recently from ad08ab7 to 44413de Compare May 6, 2022 13:59
@davidbrochart davidbrochart force-pushed the save_yjs branch 3 times, most recently from b1b9e06 to c9452f8 Compare July 6, 2022 10:33
@davidbrochart
Copy link
Collaborator Author

I rebased and squashed.
It should now be in line with JupyterLab v4.0.0a26.

@davidbrochart davidbrochart marked this pull request as ready for review July 6, 2022 11:06
@davidbrochart davidbrochart merged commit 809150f into jupyter-server:main Jul 6, 2022
@davidbrochart davidbrochart deleted the save_yjs branch July 6, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@davidbrochart