Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves the frontend generic configuration to a new plugin #231

Merged
merged 4 commits into from Sep 20, 2022

Conversation

hbcarlos
Copy link
Contributor

cc @davidbrochart

This PR moves the generic frontend configuration to a new plugin.

The idea is that another fps-base app could reuse the kernel plugin without depending on the fps-lab plugin, being able to implement a new frontend that reuses the kernel plugin.

@hbcarlos
Copy link
Contributor Author

I believe the Check Release workflow is failing because of an unrelated issue. It is failing in the main branch too, and I think it is related to the order used to install the packages in the step check-python.

Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Carlos!
The Check Release workflow is failing because we have not published fps-frontent to PyPI yet, so that's expected. I'll do it after merging this PR.
@blink1073 mentioned that jupyter-releaser should support local packages though, but I don't know if there's something to do to enable that?

plugins/kernels/fps_kernels/routes.py Outdated Show resolved Hide resolved
plugins/lab/fps_lab/routes.py Outdated Show resolved Hide resolved
plugins/lab/fps_lab/routes.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@hbcarlos
Copy link
Contributor Author

Thanks, @davidbrochart! I pushed a commit with the changes.

@davidbrochart davidbrochart merged commit dc641b3 into jupyter-server:main Sep 20, 2022
@blink1073
Copy link

local packages

It should already be doing that in check release, using a local pypi server, but that server only serves files that you've published.

@hbcarlos hbcarlos deleted the frontend_config branch September 20, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants