Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SplitMapControl not working locally #1066

Closed
raybellwaves opened this issue Oct 19, 2022 · 9 comments · Fixed by #1135
Closed

SplitMapControl not working locally #1066

raybellwaves opened this issue Oct 19, 2022 · 9 comments · Fixed by #1135
Labels

Comments

@raybellwaves
Copy link

I tried to run https://ipyleaflet.readthedocs.io/en/latest/controls/split_map_control.html locally

I get a strange behavior where the slider does not work and it only drags the image underneath it. What information can I provide to help debug this?

Screen.Recording.2022-10-19.at.1.34.15.PM.mov
@martinRenou
Copy link
Member

I can replicate this issue as well. Something may have changed in LeafletJS that broke the SplitMap extension.

@raybellwaves
Copy link
Author

I can replicate this issue as well. Something may have changed in LeafletJS that broke the SplitMap extension.

Is there a way to test against different versions of Leaflet? https://github.com/Leaflet/Leaflet/tags

@martinRenou
Copy link
Member

The only thing you can try is downgrade ipyleaflet until the SplitMap control works again. Unless you want to try and make a dev install of ipyleaflet and downgrade LeafletJS in the source, which I would probably not recommend.

@giswqs
Copy link
Contributor

giswqs commented Oct 28, 2022

I just ran into the same issue. Waiting for a fix.

@jportolese
Copy link

Same here. Has anyone found a version that doesn't have this issue?

@jportolese
Copy link

I had ipyleaflet 0.17.2 installed and it didn't work
I tried 0.17.0, 16, 15, 14 and none of them make a difference. That goes back to June 17, 2021. Has this been an issue for longer than that?

@BoineeloMoyo
Copy link

Was the issue ever solved..? i have the same problem. What version of ipyleaflet works perfect with the splitmap

@lachlanfrancis
Copy link

I had this issue; and believe an update to the documentation is required (raised in #1115).
Adding dragging = False to my Map allowed the slider to work without trying to drag the base map.

m = Map(center=(42.6824, 365.581), zoom=5, dragging = False)

@martinRenou
Copy link
Member

https://github.com/QuantStack/leaflet-splitmap has been released with I believe contains the patch required to fix this issue.

ipyleaflet would need to be rebuilt with this new version. Happy to review a PR if someone wants to tackle this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants