Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipyleaflet not working properly with JupyterLab 4.x #1125

Closed
giswqs opened this issue Jul 15, 2023 · 6 comments
Closed

ipyleaflet not working properly with JupyterLab 4.x #1125

giswqs opened this issue Jul 15, 2023 · 6 comments

Comments

@giswqs
Copy link
Contributor

giswqs commented Jul 15, 2023

It appears that JupyterLab 4.x breaks some ipyleaflet functionality. Changing map attributes (e.g., zoom, center) has no effect. It works fine in VS Code.

In JupyterLab:
Peek 2023-07-14 23-10

In VS Code:
Peek 2023-07-14 23-13

@martinRenou
Copy link
Member

Thank you for opening an issue. Would you be able to provide the JavaScript console errors, if there are any?

@giswqs
Copy link
Contributor Author

giswqs commented Oct 6, 2023

See jupyterlab/jupyterlab#14829 (comment)

@dfguerrerom
Copy link

@giswqs you might want to see openforis/sepal#304.

@jhgoebbert
Copy link

I came across this fork which claims to run with JupyterLab>4. Perhaps it is possible to merge the commits from there.
https://github.com/cdanielw/ipyleaflet

@cdanielw
Copy link
Contributor

Together with that fork, I uploaded a pre-built release we use in SEPAL, as an interim solution:

pip install https://github.com/cdanielw/ipyleaflet/releases/download/0.17.4/ipyleaflet-0.17.4-py3-none-any.whl

I never bothered to make a pull request, as I assume the ipyleaflet guys are on-top-of this issue. I just needed an immediate way to get this running.

@martinRenou
Copy link
Member

If you could open a PR that would be great. We need help maintaining this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants