Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding more exeptions #98

Open
MCWertGaming opened this issue Mar 2, 2021 · 0 comments
Open

adding more exeptions #98

MCWertGaming opened this issue Mar 2, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MCWertGaming
Copy link
Collaborator

cpp-terminal is currently not checking that much for legal inputs on some functions. For example: Term::Window_24bit scr(0, 0, 10, 10); returns a segmentation fault, because the used vectors of the window class can't have negative places. we should simply throw a std::runtime_error here. That would include:

  • Term::Window
  • Term::Window_24bit
  • (with some functions, like Term::Window::fill_bg)
  • Term::color
  • Term::color_24bit
    and probably all other functions without enforced types (like enums)
@MCWertGaming MCWertGaming mentioned this issue Mar 16, 2021
42 tasks
@MCWertGaming MCWertGaming added this to To do in CPP-Terminal Dec 6, 2021
@MCWertGaming MCWertGaming self-assigned this Dec 7, 2021
@MCWertGaming MCWertGaming added the enhancement New feature or request label Dec 7, 2021
@MCWertGaming MCWertGaming added this to the V1.X.X milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

1 participant