Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

bower install of elements freezes server #43

Closed
jhpedemonte opened this issue Oct 16, 2015 · 5 comments
Closed

bower install of elements freezes server #43

jhpedemonte opened this issue Oct 16, 2015 · 5 comments

Comments

@jhpedemonte
Copy link
Contributor

Noticed yesterday when downloading threejs (which takes a while) that the bower install of elements completely freezes the server, such that I can't load or work on a different notebook. If possible, bower install should be handled asynchronously so as not to bog down everything else.

@parente
Copy link
Member

parente commented Oct 16, 2015

The subprocess call here:

https://github.com/jupyter-incubator/declarativewidgets/blob/master/nb-extension/python/urth/widgets/urth_import.py#L26

can be made asynchronous with:

http://tornado.readthedocs.org/en/latest/process.htmlhighlight=subprocess#tornado.process.Subprocess

The issue then is how to design the flow of execution between the backend installing elements and the frontend trying to use them so that issue #25 is not made worse by the asynchronous call.

@zackmorris
Copy link
Contributor

I'm looking into switching the subprocess call to use Tornado's subprocess function.

@parente
Copy link
Member

parente commented Oct 20, 2015

Be aware that this fix is going to further break #25 which probably needs to be fixed first or in parallel.

@zackmorris
Copy link
Contributor

#61 has the aforementioned changes to the subprocess call.

We're going to need add a queue for tracking the state of each package's installation progress. This will prevent overlapping dependencies by maintaining a sequential installation of packages based off of the order they were sent to the server.

@lbustelo
Copy link
Collaborator

We are going to put this on hold for now to first figure out the best way to reliably have Run All work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants