Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Docker images necessary for development are out of date #46

Closed
wellecks opened this issue Oct 19, 2015 · 9 comments
Closed

Docker images necessary for development are out of date #46

wellecks opened this issue Oct 19, 2015 · 9 comments

Comments

@wellecks
Copy link
Contributor

The cloudet/pyspark-notebook-bower-sparkkernel and cloudet/sbt-sparkkernel-image images used in the Makefile contain an old version of the Spark Kernel.

Crucially, this old version doesn't have the fix for defect 137 which is necessary for properly displaying the Scala widgets, e.g. in the urth-core-scala.ipynb examples notebook. As a result, it's difficult to introduce and test new features on the Scala widgets.

@parente
Copy link
Member

parente commented Oct 21, 2015

It would be good to get the underlying cloudet/pyspark-notebook-bower out here too. (It's still buried in our internal git server). I think widgets is the right place for it to live because node / npm / bower is a hard dep of widgets, but a soft dep of dashboards.

Ping me for the link.

@lbustelo
Copy link
Collaborator

@parente I know where the Dockerfile is. I'll take care of it.

Gino B.

On Oct 21, 2015, at 9:33 AM, Peter Parente notifications@github.com wrote:

It would be good to get the underlying cloudet/pyspark-notebook-bower out here too. (It's still buried in our internal git server). I think widgets is the right place for it to live because node / npm / bower is a hard dep of widgets, but a soft dep of dashboards.

Ping me for the link.


Reply to this email directly or view it on GitHub.

@parente
Copy link
Member

parente commented Oct 21, 2015

👌

@lbustelo
Copy link
Collaborator

For this we are going to do a couple of things.

  • Create Dockerfile and Makefile to build and push the image we would use for dev based on jupyter/all-spark-notebook and add bower. Call it cloudet/all-spark-notebook-bower.
  • Build an updated version of cloudet/sbt-sparkkernel-image that brings in the later spark kernel.
  • Push images to docker hub
  • Modify our main Makefile and .travis.yml change to use cloudet/all-spark-notebook-bower. verify README.md

@lbustelo
Copy link
Collaborator

I'm taking this one

@lbustelo lbustelo self-assigned this Oct 21, 2015
@lbustelo
Copy link
Collaborator

Latest WIP is at #66

@lbustelo
Copy link
Collaborator

@wellecks pushed tags for the currently registered image for building scala support. This will avoid the possibility of overwriting he current support in case of any issue. I should be able to push early tomorrow.

@lbustelo
Copy link
Collaborator

All changes are in PR #66. Now lets see what travis says...

@lbustelo
Copy link
Collaborator

We now docker image cloudet/all-spark-notebook-bower. The Dockerfile and Makefile is held by this project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants