Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try pypy-based image #1193

Closed
mathbunnyru opened this issue Nov 29, 2020 · 8 comments
Closed

Try pypy-based image #1193

mathbunnyru opened this issue Nov 29, 2020 · 8 comments

Comments

@mathbunnyru
Copy link
Member

Now, using miniforge, we may be able to try PYPY based images quite easily.
I'm not sure it would work and that it would be that easy, but it might give significant performance improvement and it that case it would be nice to have a choice.

For example, scipy-notebook-python and scipy-notebook-pypy would be fine for me.

@bollwyvl
Copy link

bollwyvl commented Nov 30, 2020 via email

@jakirkham
Copy link
Member

cc @mattip (who may be interested in this 😉)

@mattip
Copy link

mattip commented Dec 1, 2020

Nice, thanks for piniging me. Do you get much feedback from end users what works for them and what doesn't?

@lima4658
Copy link

lima4658 commented May 30, 2021

PyPy migration on conda-forge works fine.
For building a pypy based scipy-notebook you have to change two lines in the base-notebook Dockerfile:
ARG miniforge_python="Mambaforge-pypy3" and the
ARG miniforge_checksum=
No futher modifications are needed.

@mathbunnyru
Copy link
Member Author

Thanks, @lima4658.
Did you try to build all the images or only scipy-notebook (and its parents)?

The thing is, that it would be nice to receive some feedback from users, that they really want these images (as you see, this thread is not really active).

And, to support these images, we will need something closely related to #1019.
I think it might be super-easy to implement pypy images after implementing multi-arch images, because customization points actually look more-or-less the same.

@lima4658
Copy link

@mathbunnyru
I build only base-notebook, minimal-notebook and scipy-notebook. As mentioned only minimal modifications in the base-notebook Dockerfile were needed. Maybe in the next days I have time to build the missing notebooks.

Is a "conda free" version based on ubuntu python packages requested? If yes let me know. I can provide versions until scipy-notebook.

@mathbunnyru
Copy link
Member Author

@mathbunnyru
I build only base-notebook, minimal-notebook and scipy-notebook. As mentioned only minimal modifications in the base-notebook Dockerfile were needed. Maybe in the next days I have time to build the missing notebooks.

Is a "conda free" version based on ubuntu python packages requested? If yes let me know. I can provide versions until scipy-notebook.

No, we use conda (or sometimes mamba) wherever possible, so, on the contrary, it would be nice to have all packages installed through conda (or mamba, which uses the same channels and packages).

@mathbunnyru
Copy link
Member Author

I didn't see much interest in pypy images, so closing this one.
Please, if someone want to make it, ping me, I can describe how to change build system to make it work.

@mathbunnyru mathbunnyru closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants