Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jupyter-book is missing from the binder requirements #166

Closed
joergbrech opened this issue Mar 27, 2019 · 2 comments · Fixed by #167
Closed

jupyter-book is missing from the binder requirements #166

joergbrech opened this issue Mar 27, 2019 · 2 comments · Fixed by #167

Comments

@joergbrech
Copy link
Contributor

jupyter-book should be added to the binder requirements, since it is needed here: https://jupyter.org/jupyter-book/features/notebooks.html, see discussion in PR #163

jupyter-book-missing
@joergbrech joergbrech mentioned this issue Mar 27, 2019
Merged
@joergbrech
Copy link
Contributor Author

Argh, this did not work, because binder is started from the gh-pages branch, which only has the requirements.txt and not the binder subfolder.

https://github.com/jupyter/jupyter-book/blob/a214af7313fea147b6915544cadee71a479a2e46/jupyter_book/book_template/_config.yml#L63

So either we should add master here, or add a line to the requirements.txt to install jupyter-book from this repo...

@emdupre
Copy link
Collaborator

emdupre commented Mar 27, 2019

Would this be something we could solve by moving to a service like netlify instead of github pages ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make sure jupyter-book is included in the binder build joergbrech/jupyter-book
2 participants
@emdupre @joergbrech