Page turn links to external sites are broken

[mwcraig]

External links are generated fine in the sidebar. In the "page turn" links at the bottom of the page they are generated as though they were internal links.

To see this, go to https://jupyter.org/jupyter-book/features/limits.html then scroll down to the bottom and hover over the "GitHub repository" link. As you can see in the screenshot, the generated link prepends the book's URL, so in this case the URL ends up being https://jupyter.org/jupyter-book/https://github.com/jupyter/jupyter-book

This link is defined in the toc at https://github.com/jupyter/jupyter-book/blob/master/jupyter_book/book_template/_data/toc.yml#L71

[choldgraf]

ah hah - that's a good catch.

For this kind of thing, what do you think is the best behavior? It feels kinda weird to leave the site by going to the "next page", although then again that is technically the book structure that's been put forward

[mwcraig]

I think it would be useful to have an option for sidebar-only links, a header with a link in the sidebar but not in the navigation. I guess Search must be handled something like that since it shows up in the sidebar but not as part of the page turn links.

I agree that suddenly navigating away from the book content is not the way to go.