Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check that generate_toc.py is getting copied properly #210

Closed
choldgraf opened this issue Jun 6, 2019 · 2 comments · Fixed by #215
Closed

Double check that generate_toc.py is getting copied properly #210

choldgraf opened this issue Jun 6, 2019 · 2 comments · Fixed by #215

Comments

@choldgraf
Copy link
Member

In #208 it seemed that generate_toc.py wasn't being properly copied over. We should double check that it's copied properly and fix it if not.

@thammegowda
Copy link
Contributor

I confirm it's not getting copied (tested on OSX)
generate_toc.py is not found in pip bundle

@thammegowda
Copy link
Contributor

$ python -c 'from setuptools import find_packages; print(find_packages())'
['jupyter_book', 'jupyter_book.commands']

So, now we know why it happened: find_packages isnt including scripts dir

and now we know how to fix it:

$ touch jupyter_book/scripts/__init__.py
$ python -c 'from setuptools import find_packages; print(find_packages())'
['jupyter_book', 'jupyter_book.scripts', 'jupyter_book.commands']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants