Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation links that are broken #224

Closed
choldgraf opened this issue Jul 3, 2019 · 4 comments
Closed

Update documentation links that are broken #224

choldgraf opened this issue Jul 3, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@choldgraf
Copy link
Member

choldgraf commented Jul 3, 2019 •
edited

In 12dd61e @habi noticed that some links that we thought were fixed are actually still broken, we should fix them!

@habi if you wanted to give it a shot (the fix would be here: https://github.com/jupyter/jupyter-book/tree/master/jupyter_book/book_template instead of in the /minimal directory) I'm happy to review a PR! :-)
@choldgraf choldgraf added the bug Something isn't working label Jul 3, 2019
@habi
Copy link
Contributor

habi commented Jul 3, 2019

I'll see what I can do, but not before next week...

habi added a commit to habi/jupyter-book that referenced this issue Jul 8, 2019
@habi
Change text in Markdown cell to correct URL.
3f8ab4e 
As 'discussed' here: executablebooks#224
@habi habi mentioned this issue Jul 8, 2019
Merged
@choldgraf
Copy link
Member Author

Is this one resolved for you now @habi?

@habi
Copy link
Contributor

habi commented Jul 9, 2019

The link on https://jupyter.org/jupyter-book/features/notebooks.html is now correct, yes.

@choldgraf
Copy link
Member Author

Thanks so much for making the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@habi @choldgraf