Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml.load() is unsafe #230

Closed
davidwagner opened this issue Jul 12, 2019 · 1 comment · Fixed by #235
Closed

yaml.load() is unsafe #230

davidwagner opened this issue Jul 12, 2019 · 1 comment · Fixed by #235
Labels
bug Something isn't working

Comments

@davidwagner
Copy link

Running jupyter-book build triggers the following warnings:

.../jupyter_book/build.py:130: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  site_yaml = yaml.load(ff.read())
.../jupyter_book/build.py:139: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  toc = yaml.load(ff.read())

Perhaps those yaml.load() calls could be using yaml.safe_load()?

@emdupre emdupre added the bug Something isn't working label Jul 15, 2019
@emdupre
Copy link
Collaborator

emdupre commented Jul 15, 2019

Thanks for reporting, @davidwagner ! This should be fixed when #235 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants