Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbar overlaps with TOC table (on Linux) #75

Closed
gaow opened this issue Jan 9, 2019 · 5 comments
Closed

Scrollbar overlaps with TOC table (on Linux) #75

gaow opened this issue Jan 9, 2019 · 5 comments

Comments

@gaow
Copy link
Contributor

gaow commented Jan 9, 2019

Take this page for example:

https://325-137292803-gh.circle-artifacts.com/0/html/features/hiding.html

Below is how it looks like on (two of) my (Debian) Linux machine running google chrome browser:

2019-01-09-10-17-15_scrot

you see how the scrollbar gets behind the TOC table. This is also true for pages generated via the current master. However your earlier version of #59,

https://85-137292803-gh.circle-artifacts.com/0/html/features/notebooks.html

does not have the problem:

2019-01-09-10-19-04_scrot

This is, however, not an issue on my Macbook running chrome. Still it would be great if we could identify the relevant changes in the CSS and fix it for Linux. I can certainly test it for your patches if there is no Linux OS or readily available VM on your end. Thanks a lot!

@gaow gaow changed the title Sidebar overlaps with TOC table (on Linux) Scrollbar overlaps with TOC table (on Linux) Jan 9, 2019
@choldgraf
Copy link
Member

Yup - agreed, @SamLau95 noticed this scrollbar effect earlier as well. I think the best thing would be for the scrollbar to always be snapped to the right side of the page, but it'll require some fiddling with the CSS to figure that out

@choldgraf
Copy link
Member

I updated the right TOC to be a little bit friendlier with respect to this issue - it's more compact and minimalistic, which should make this less-noticeable. What do you think?

image

@gaow
Copy link
Contributor Author

gaow commented Jan 9, 2019

Thank you @choldgraf! Truthfully I do not know. Whenever it comes to aesthetics I would respect opinion of other people (in this case you and your team). But being able to solve the overlapping scrollbar issue is certainly a plus for this new style! I'll leave the aesthetics decision to you :)

@choldgraf
Copy link
Member

haha - well, if worst comes to worst folks can always add their own CSS :-) if you think this issue is resolved, feel free to close!

@gaow
Copy link
Contributor Author

gaow commented Jan 10, 2019

Thanks a lot :)

@gaow gaow closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants