Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe not rendering #91

Closed
emdupre opened this issue Jan 30, 2019 · 8 comments
Closed

iframe not rendering #91

emdupre opened this issue Jan 30, 2019 · 8 comments

Comments

@emdupre
Copy link
Collaborator

emdupre commented Jan 30, 2019

I've created some interactive brain images using nilearn's plotting calls to brainsprite.js. The images look lovely in a jupyter notebook, and when I render the notebook with nbconvert they still look lovely and retain interactivity. But when I try to put the executed notebooks into jupyter-book, I get an unrendered iframe:

screenshot from 2019-01-30 15-28-37

Any ideas what could be going on here, or how to start tackling this ? Thanks as always !

@choldgraf
Copy link
Member

hmmmmmmmmm could you give a link to your repo? How does the iframe code look in the markdown?

@emdupre
Copy link
Collaborator Author

emdupre commented Jan 30, 2019

Thanks for the quick reply ! The repo is here, but I realized the error is creeping in the nbconvert conversion to markdown (the conversion to html works fine). I'll close this since it doesn't seem to be a jupyter book problem :)

@emdupre emdupre closed this as completed Jan 30, 2019
@choldgraf
Copy link
Member

know what was going wrong? was it losing some text or something?

@emdupre
Copy link
Collaborator Author

emdupre commented Jan 30, 2019

It looks like it's cutting in the middle -- attaching two text files here, one with what's rendered in the markdown doc and one with what's in the raw markdown text but not rendering in the markdown preview:

unrender_text.txt
rendered_text.txt

Edited to add: this is converting a different brainsprite, so the text might not match up exactly to what I previously reported, though the behavior is the same. I can also share text for the original sprite, if that's helpful !

@choldgraf
Copy link
Member

ah - I think this is related to: #72

@emdupre
Copy link
Collaborator Author

emdupre commented Jan 31, 2019

Thanks so much for the pointer ! That's super helpful.

A beginner question: there you were able to figure out that it was an unquoted col attribute. Any recommendations on how to track down the problem ? Or if you have other resources to point to, I'd appreciate it ! Sorry for the noise.

@choldgraf
Copy link
Member

in my case, I saw lots of "&" signs (I think it was &) and was like "huh that doesn't look like normal HTML". Then I looked up the encoding symbols in HTML and had my ah-hah moment :-)

@emdupre
Copy link
Collaborator Author

emdupre commented Feb 6, 2019

Update: unquoted attributes were exactly the problem

choldgraf added a commit to choldgraf/jupyter-book that referenced this issue Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants