Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add google analytics option #116

Merged
merged 5 commits into from
Feb 26, 2019

Conversation

joergbrech
Copy link
Contributor

@choldgraf, you mentioned in #115 you wanted some documentation on how to add the tracking code. Where would that go?

fixes #115

@emdupre
Copy link
Collaborator

emdupre commented Feb 26, 2019

This is amazing, thanks @joergbrech !

One idea would be to put it in the How-to and advanced topics section, so in this markdown. WDYT ?

Add some documentation for jupyter-book#115
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks for the improvement! Two quick nitpicks and I think it looks ready to go

jupyter_book/book_template/_includes/analytics.html Outdated Show resolved Hide resolved
jupyter_book/book_template/content/guide/05_advanced.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! If @emdupre is happy w/ it, I am +1 on merge! Feel free to press the green button @emdupre :-)

@emdupre
Copy link
Collaborator

emdupre commented Feb 26, 2019

Thanks again, @joergbrech ! Merging now ✨

@emdupre emdupre merged commit 19817d5 into jupyter-book:master Feb 26, 2019
@choldgraf
Copy link
Collaborator

yahoo 💯

choldgraf added a commit to choldgraf/jupyter-book that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option / config for analytics tracking?
3 participants