-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding nbinteract support #119
Conversation
For some reason this still isn't yet working...the kernel seems to correctly connect upon landing on the page, but:
|
3c5c184
to
d03ee22
Compare
@choldgraf is this ready to use? I am happy to give it a test drive if you want. I have some interacts in my jupyter-book and I'd love to try this out. |
No tests updated? :) |
nope not yet, I'm supposed to chat with @SamLau95 sometime this week to explain how to best-use nbinteract, I couldn't quite figure it out :-) |
Notes from a chat with @SamLau95 Here's what nbinteract does: when you click a button that launches nbinteract, it will do the following:
Normally, nbinteract uses a custom liquid template in order to add the We should do something like:
|
Wooo, got it working :-) thanks @SamLau95 for the advice: https://811-137292803-gh.circle-artifacts.com/0/html/features/interact.html now how the heck do we add a test for this 0.o |
@choldgraf when I click the "show widgets" button, it's stuck forever ... |
@jasmainak can you try clicking it again after waiting a moment? It took a second for nbinteract to initialize for me (I just tried the latest build and it seemed to work)...alternatively can you check the JS console to see if there are any errors? |
hmm ... it did work this time. But it took a while. Could this button be added next to all the widgets? Just like in the nbinteract documentation page? |
we could do it that way as well with some modifications to the templates...I was thinking that it'd be simpler to just have it at the top (since once it's been activated once, it'll auto-activate in subsequent runs, and since clicking any one button will activate all of the widgets). Do you feel strongly on that one? |
umm ... not too strongly, but I think the other one is more intuitive. At the moment, I am struggling to explain to people how to use the jupyter-book. Nobody seems to notice the buttons ... maybe it will be easier when I demo in person. |
b719328
to
14d8922
Compare
ok, I think this is pretty much ready to go except for tests https://874-137292803-gh.circle-artifacts.com/0/html/features/interact.html @SamLau95 do you have any recommendations for how to test nbinteract support? |
@choldgraf One simple method is to make sure that the nbinteract-specific button(s) are present after converting notebooks into HTML. |
I meant more like testing on the Javascript side :-) How did you test that kinda stuff in nbinteract? e.g., that when I click the button, the binder kernel properly connects etc |
I'm gonna merge this in because it updates some of the cell CSS structure and could be useful in other PRs as well - we can iterate on the UI for nbinteract later on to see how it feels |
* Add mini example to intro page
This PR adds support for nbinteract which lets you display interactive widgets powered by Binder. It is originally developed by @SamLau95 who also helps out with jupyter-book!
@SamLau95 if you have a moment, could you see if there's anything wrong with this implementation? I tried to mimic what you're doing on DS100...I don't quite have it working the way we'd like to properly ask Binder for a kernel and/or display update messages, any help would be appreciated
closes #82