[FIX] Issue #137 Errors when running on Windows #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
very nice! thanks! I don't think we can really test this specifically since it's windows-specific and we don't have access to those build environments, so I'll give this a few hours to see if anyone has thoughts and, if not, will give it a merge! |
|
merge! thanks :-) |
|
@KirstieJane this might solve some of your local build problems ! If you don't feel like using containers 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the 'encoding' parameter to the open() function in the file handler allowed for proper book building as expected in a Windows 10 environment.
I went through the code base and found a few other file handle operations that do not declare the encoding when reading. While this is unlikely to be an issue when writing (especially since the output is formatted using the yaml library), this type of bug may be possible on the other read operations.