Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue template #393

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Conversation

choldgraf
Copy link
Member

I accidentally committed an issue template directly to master instead of making a PR, so this PR fixes it up a bit and also leaves it open for folks to comment.

@emdupre I'd love to know what you think about this template!

@emdupre
Copy link
Collaborator

emdupre commented Oct 11, 2019

🙌 Big up on issue templates !

Looking through it has brought up two small questions, in my mind:

  1. Should we link the contributing guide, particularly the section on how we view issues ?
  2. Is it worthwhile to also point people to Jupyter Discourse ? I haven't seen a lot of Jupyter Book discussion in that space, yet, but it might make sense to encourage some of it there if we think we're likely to get more community engagement. We'd probably also want to update adding code structure and moving contributing guide #394 if so.

@choldgraf
Copy link
Member Author

Good call on both - let's wait until #394 is merged and then add a link to it from here.

For your second question, what do you think about adding a "publishing" section here: https://discourse.jupyter.org/c/special-topics and linking to that?

@emdupre
Copy link
Collaborator

emdupre commented Oct 11, 2019

what do you think about adding a "publishing" section here: https://discourse.jupyter.org/c/special-topics and linking to that?

Sure, that sounds great ! We can move it to a main topic, later, if it continues to grow (which I hope it will !) ?

@choldgraf
Copy link
Member Author

OK, updated the text to include the links we mentioned above. Let me know what you think!

@choldgraf
Copy link
Member Author

I don't believe the failing test is related to this (it's an anaconda install bug) so I'm gonna merge this one away! thanks for the feedback :-)

@choldgraf choldgraf merged commit 25e3295 into executablebooks:master Oct 18, 2019
@choldgraf choldgraf deleted the issue_template branch October 18, 2019 23:02
@choldgraf choldgraf added the bug Something isn't working label Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants