adding code structure and moving contributing guide #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choldgraf
force-pushed
the
developer_guide
branch
from
852e7d0
to
b942db5
Compare
emdupre
reviewed
Oct 11, 2019
|
|
||
| The current list of labels are [here][link_labels] and include: | ||
|
|
||
| * [][link_helpwanted] *These issues contain a task that a member of the team has determined we need additional help with.* |
There was a problem hiding this comment.
For some reason the rendering of these badges is off -- they're floating in the center of the page (and by "for some reason" I mean "I think because of our CSS rules"). I don't love how they look as a result. WDYT of removing them ?
Merged
Co-Authored-By: Elizabeth DuPre <emd222@cornell.edu>
Co-Authored-By: Elizabeth DuPre <emd222@cornell.edu>
|
Good catch @emdupre - I merged in your commits, and the latest push tries to fix the issue w/ inline images. I think this was worth fixing here, because that issue was going to be the case for anybody that applied an inline image, which doesn't seem great :-P Take a look and LMK what you think! |
choldgraf
force-pushed
the
developer_guide
branch
from
05aa918
to
963039e
Compare
|
Looks great ! Good call on not just giving up on the inline images 😅 they look perfect, now. |
emdupre
approved these changes
Oct 11, 2019
|
yay! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
CONTRIBUTING.mdfile to that page, in the hopes that it makes the page more discoverable.@emdupre did all the hard work getting this guide up in the first place, so I'd love to hear what she think about this move!
Here's a link to the contributing guide page: https://deploy-preview-394--jupyter-book.netlify.com/contributing.html
and here's a link to the new section: https://deploy-preview-394--jupyter-book.netlify.com/contributing.html#Repository-Structure-of-Jupyter-Book