-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring sidebar highlighting and allowing collapsed subsections #412
Conversation
60e8e9a
to
04da8d0
Compare
Sorry for the slow reply on this. I finally got a chance to test it out today, and it seems to be working splendidly. Thank you very much @choldgraf!! |
Sounds good - the failing test is for the CircleCI build because Ruby is having a hard time installing one of the dependencies. I'm not sure why that is, but all the other tests are passing, so I'm gonna merge this one |
Is it a way to turn |
What is it you wish to do exactly? You want to make the button to close the sidebar be invisible on some pages? Why do you not want readers to be able to close the sidebar? |
It doesn't necessary has to be a button for reader. I wish the writer can set whether a page will collapse the sub-sections within a non-active section in the sidebar (not the entire sidebar).
BTW, I opened a new issue for this: #1792 |
Any updates? Much appreciate it. |
This moves the logic for sidebar highlighting outside of the HTML template, and into a bit of javascript. The main goal is to make it more maintainable and understandable, and also to make it possible for sub-sections to be collapsed if wished
@drbeane do you wanna give this branch a shot and see if that gets your sub-section collapsing properly?
closes #407