Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ with guidelines for Plotly #97

Merged
merged 1 commit into from Feb 8, 2019
Merged

Update FAQ with guidelines for Plotly #97

merged 1 commit into from Feb 8, 2019

Conversation

mathieuboudreau
Copy link
Contributor

From #93.

I wasn't sure if only the original ("content/") *.md file is needed prior to a PR, or if you prefer make book also be run so that the "_build/" file is generated and also included. I checked your wiki for any contribution guidelines but there were none.

@choldgraf
Copy link
Member

This looks great, thanks very much for the contribution :-)

re: contributing, that is a good point! I haven't had the cycles to add that in but I'll add an issue about this so we keep track of it. The answer to your specific question is that CircleCI actually builds the book files and pushes the HTML to the gh-pages branch in the CI/CD process!

@choldgraf choldgraf merged commit 47473b4 into executablebooks:master Feb 8, 2019
choldgraf added a commit to choldgraf/jupyter-book that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants