-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with ipywidgets? #3
Comments
I can 2 several reasons :
But I don't see any reasons not to in the long run . |
OK let me ellaborate on that:
There are already many packages in the
We think that the lines of divide between these different packages are the right ones. ipywidgets is installed with the kernel and the other packages are installed with the notebook server. Since the sphinx extension is a rather standalone one, it is already better to make it external. The first one to be split off after 6.0 will probably be the schema spec (widgets counterpart to nbformat).
A common pattern we see with sphinx extension is to have multiple regrouped under a single package |
I guess the Sphinx extension has to access some JavaScript files to include them in the Sphinx output, right? But regardless of all those technical reasons for and against it, I think it would be much better for the user experience if users wouldn't have to select yet another package for download. @SylvainCorlay What would that other extension be? |
The javascript is fetched from a cdn at the moment.
I think that the ipywidgets repo is already overcrowded. I would actually like to split it in a number of smaller projects with a clearer separation of concerns. |
OK, makes sense. I'm mainly concerned about the usage of widgets together with |
That would make sense to me. Besides, we will probably have multiple flavors of the embedder. The one currently on the cdn deals with custom widgets by also fetching them on the cdn. We will probably have a version of the embedder that only looks for custom widget code locally. |
This is because it is not a resolved matter that I did not include the script tag in nbsphinx in the PR dealing with the mime type, leaving the responsibility to the client to add more script tags. But we do need to deal with this issue. |
Closing this one. Will open new issues on the options to use another url for the embedder. |
For reference: jupyter-widgets/ipywidgets#2284 |
I don't really understand why this has to be a separate download for people to worry about.
What about moving what is now
jupyter_sphinx.embed_widgets
into the main ipywidgets package?There is already a dependency to that anyway.
Then users would only need to install ´ipywidgets´ (which they most likely have installed already) and include it in their
conf.py
, e.g. like so:The text was updated successfully, but these errors were encountered: