Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup linter for HTML/CSS & Cleanup website, #104

Closed
Carreau opened this issue Jun 23, 2016 · 4 comments
Closed

Setup linter for HTML/CSS & Cleanup website, #104

Carreau opened this issue Jun 23, 2016 · 4 comments

Comments

@Carreau
Copy link
Member

Carreau commented Jun 23, 2016

While reviewing the great work of @charnpreetsingh185, @spoorthyv and @faricacarroll in #103 I realize that the current website is not using a lot of best practices and does many things wrong (62 w3c validation error on the index page) . So we are building things on quicksand.

It would be nice to spend some cycle cleaning this up. It's not lost time it will make everyone work simpler as the bad HTML and CSS will introduce unexpected rendering problem and complexity in writing correct CSS> .

@willingc can you try to manage part of that ? I know that Brian

@willingc
Copy link
Member

willingc commented Jun 23, 2016

@Carreau Thanks for reviewing the interns work :D They are really dedicated ☀️

I agree it would be good to spend some cycles on clean up. Let's see if we can break down the clean up into a plan with concrete steps. This would simplify tracking and execution by all of us.

Plan

  • Identify tool(s) to be used for validation
  • Determine the best order to address errors and warnings
    • Errors (Currently, 51 errors)
    • Warnings (Currently, 11 warnings)
  • Correct errors by error type (It looks like there are 3 categories)
    • An img element must have an alt attribute, except under certain conditions.
    • Duplicate ID tab.
    • Element ___ not allowed as child of element ___ in this context.

screen shot 2016-06-23 at 11 32 44 am

  • Correct warning type (4 categories of warnings found)

screen shot 2016-06-23 at 11 36 11 am

Matthias, Let's decide on the tool(s) and I'm assuming it's better to fix errors before warnings. Once you and I decide on the tool(s) for validation, we can assign the interns a subset of errors. What do you think?

@Carreau
Copy link
Member Author

Carreau commented Jun 23, 2016

We should likely have a css linter as well, I also edited above to add that if we want to test on travis, we need to setup a build on Travis.

@willingc
Copy link
Member

Any suggestions on a css linter? Any thoughts on setting up Travis before or after all the changes?

@willingc
Copy link
Member

Travis is up and running! 🎉

Summary of work still to be done

HTML errors and warnings to be corrected

  • Duplicate ID tab.
  • Element ___ not allowed as child of element ___ in this context.
    screen shot 2016-06-23 at 11 32 44 am
  • Correct warning type (4 categories of warnings found)

screen shot 2016-06-23 at 11 36 11 am

CSS warnings to be corrected

  • Warnings as reported by CSSLint on Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants