Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel can only autorestart once #689

Closed
mofanke opened this issue Sep 14, 2021 · 5 comments
Closed

kernel can only autorestart once #689

mofanke opened this issue Sep 14, 2021 · 5 comments

Comments

@mofanke
Copy link
Contributor

mofanke commented Sep 14, 2021

kernel can only autorestart once
Name: jupyter-client
Version: 7.0.2

kill kernel process first time, it will autorestart . kill it agian , nothing will happen

@mofanke
Copy link
Contributor Author

mofanke commented Sep 14, 2021

seems self.shutting_down in KernelManager never set to False ,after restart

@kevin-bates
Copy link
Member

Hmm - I'm not experiencing this. If I kill the kernel pid, the auto-restart takes place each time (across all 3 attempts). That said, I see what you mean regarding self.shutting_down and it seems it deserves a reset in the post start method. Did you want to take a crack at this? Since I'm not reproducing this, it would be good for you to at least check out the solution (from wherever that comes).

@mofanke
Copy link
Contributor Author

mofanke commented Sep 16, 2021

this issue occurred when jupyter-client==7.0.2, and i add "self.shutting_down = False" in funciton "async def _async_post_start_kernel(self, **kw) -> None:" it will be ok

@kevin-bates
Copy link
Member

Hi @mofanke - thanks for the update.

Yes, that sounds like the correct approach. Did you want to go about creating a pull request for this?

@mofanke
Copy link
Contributor Author

mofanke commented Sep 27, 2021

fixed

@mofanke mofanke closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants