Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'jupyter kernel' command #240

Merged
merged 7 commits into from Dec 12, 2017

Conversation

@takluyver
Copy link
Member

takluyver commented Feb 10, 2017

A simple lead in to the 'kernel nanny' work, this adds a command so you can do:

jupyter kernel --kernel python

I intend this for post-5.0.

@takluyver takluyver added this to the 5.1 milestone Feb 10, 2017
@rgbkrk

This comment has been minimized.

Copy link
Member

rgbkrk commented Feb 10, 2017

Could this be tested?

from .kernelspec import KernelSpecManager
from .manager import KernelManager

class KernelApp(JupyterApp):

This comment has been minimized.

Copy link
@minrk

minrk Feb 13, 2017

Member

docstrings anywhere?

@minrk

This comment has been minimized.

Copy link
Member

minrk commented Feb 13, 2017

Very nice! I'd love a test to get basic exercise of the signal stuff.

@minrk minrk modified the milestones: 5.1, 5.2 Jun 22, 2017
@rolweber

This comment has been minimized.

Copy link
Contributor

rolweber commented Aug 10, 2017

Is this related to issue #32?

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Aug 10, 2017

Yep, it is. I've basically stopped trying to work on everything related to the 'kernel nanny' proposal (jupyter/enhancement-proposals#14) for now, though, because I don't have a good enough feel for the problem.

This will probably also need to be updated in light of #261, if that goes forward.

takluyver added 4 commits Feb 10, 2017
A simple lead in to the 'kernel nanny' work, this adds a command so you
can do:
jupyter kernel --kernel python
@takluyver takluyver force-pushed the takluyver:jupyter-kernel-cmd branch from f6e9610 to 7e6d167 Dec 11, 2017
@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Dec 11, 2017

I've come back to this following a recent email. I've added some docstrings and a rather crude test.

@minrk
minrk approved these changes Dec 12, 2017
@minrk minrk merged commit 7bbb56d into jupyter:master Dec 12, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk

This comment has been minimized.

Copy link
Member

minrk commented Dec 12, 2017

Great! Thanks for coming back to this one.

@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Dec 15, 2017

@meeseeksdev backport

@meeseeksdev

This comment has been minimized.

Copy link

meeseeksdev bot commented Dec 15, 2017

There seem to be a conflict, please backport manually

takluyver added a commit that referenced this pull request Dec 15, 2017
A simple lead in to the 'kernel nanny' work, this adds a command so you can do:

```
jupyter kernel --kernel python
```

I intend this for post-5.0.

Signed-off-by: Thomas Kluyver <thomas@kluyver.me.uk>
@takluyver takluyver deleted the takluyver:jupyter-kernel-cmd branch Dec 15, 2017
@takluyver

This comment has been minimized.

Copy link
Member Author

takluyver commented Dec 15, 2017

Backported manually.

@jakirkham

This comment has been minimized.

Copy link
Member

jakirkham commented Dec 18, 2017

Have you explored using pytest-runner? Also have found this suggestion helpful when working with pytest-runner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.