Set secure cookie by default if login handler is hit. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| class LoginHandler(IPythonHandler): | ||
| """The basic tornado login handler | ||
|
|
||
| authenticates with a hashed password from the configuration. | ||
| """ | ||
|
|
||
| secure_cookie = Bool(default_value=True, help="""set login cookie "secure" flag, so it will""" |
|
used settings.get, fallback on request protocol if not set. |
| @@ -37,7 +37,8 @@ def post(self): | |||
| typed_password = self.get_argument('password', default=u'') | |||
| if self.login_available(self.settings): | |||
| if passwd_check(self.hashed_password, typed_password): | |||
| self.set_secure_cookie(self.cookie_name, str(uuid.uuid4())) | |||
| self.set_secure_cookie(self.cookie_name, str(uuid.uuid4()), | |||
| secure=self.settings.get('secure_cookie', (self.request.protocol == 'https')) | |||
There was a problem hiding this comment.
as discovered on JupyterHub, secure=False doesn't actually work. The secure kwarg can only be specified when it should be True (a bug in Tornado, fixed in 4.2)
There is few chances that logged-in people do not use https connexion, but I guess it can happened if the server is ran in front of a proxy that does the https termination, so leave it configurable. closes ipython/ipython#8325
minrk
added a commit
that referenced
this pull request
Apr 17, 2015
Set secure cookie by default if login handler is hit.
|
shoudl I mark that as backport ? |
|
I don't think it's useful to mark for backport, since we can't backport automatically anymore. It probably makes sense to open a PR against 3.x, though. |
Carreau
added a commit
to Carreau/ipython
that referenced
this pull request
Apr 17, 2015
backport of jupyter/notebook#22 b8e99bc > There is few chances that logged-in people do not use https connexion, > but I guess it can happened if the server is ran in front of a proxy > that does the https termination, so leave it configurable. > > closes ipython#8325
bollwyvl
pushed a commit
to bollwyvl/notebook
that referenced
this pull request
Mar 21, 2016
use import_item to allow any module to provide an nbextension
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is few chances that logged-in people do not use https connexion,
but I guess it can happened if the server is ran in front of a proxy
that does the https termination, so leave it configurable.
closes ipython/ipython#8325