Allow params to terminal api endpoint #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green! Merging away! |
|
🎉 |
|
@Zsailer thank you! |
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
* adding cwd param to terminal api endpoint * Adding terminal tests and new terminal kwargs * fixing fetch method in terminal tests * attempting to fix windows tests for terminal * fixing condition for windows in terminal tests * Updating terminal tests to skip windows * skip terminal tests on windows Co-authored-by: qntnrbns <quinton.robbins@kaleopharma.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up from #160.
Following jupyter/notebook's lead, we're going to skip the tests for the terminal API on Windows due to timeouts on CI.
Thanks, @qntnrbns, for your work on this (and my apologies for our slowness to update!). This was already reviewed in #160, so I'll merge immediately once CI passes.