Track linked extensions in extension manager #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
* more clear status messages for pending kernels * Bump to 0.15.0 * bug in provisioner
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Track linked extensions in extension manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic is missing in #248, so I've added it here.
The
linked_extensionproperty tracks if an extension has already been initialized and linked to a ServerApp. It was originally added for nbclassic when handling the shimming of server extensions. (This missing logic hasn't caused any issues because nbclassic is appending extensions directly to the private property,_linked_extensions).This missing public-facing property became an issue when drafting jpserver-extension-check. I want to use this property to verify that extensions are linked properly in those tests.