Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jupyter_client #62

Merged

Conversation

SylvainCorlay
Copy link
Contributor

@SylvainCorlay SylvainCorlay commented Jul 10, 2019

To drop the faulty 5.3.0

@rolweber
Copy link
Contributor

The AppVeyor tests for Python 2.7 fail, apparently because the zmq DLL cannot be loaded. Maybe a temporary problem during setup of the test - but I don't know how to restart it.
The corresponding tests in Travis worked, but those are Linux rather than Windows.

Makes me wonder when would be the right time to drop support for Python 2.7.

Copy link
Contributor

@rolweber rolweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SylvainCorlay
Copy link
Contributor Author

Thanks @rolweber it seems the culprit is the recent update of zeromq on conda-forge (one day ago).

I have reported the issue upstream and to @minrk.

@SylvainCorlay SylvainCorlay merged commit 1a0defc into jupyter-server:master Jul 10, 2019
@SylvainCorlay SylvainCorlay deleted the update-jupyter-client branch July 10, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants